Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

feat(TypeScript): use ts-loader instead of awesome-typescript-loader #738

Merged
merged 4 commits into from
Dec 14, 2018
Merged

feat(TypeScript): use ts-loader instead of awesome-typescript-loader #738

merged 4 commits into from
Dec 14, 2018

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Dec 12, 2018 •
edited
Loading

We executed some performance tests to compare ts-loader and awesome-typescript-loader. The difference in the build time between the two is insignificant. On the other hand, the ts-loader is 50% smaller than awesome-typescript-loader and is a dependency of the nativescript-dev-webpack package because it is needed in the {N}-Vue projects anyway.

@sis0k0 sis0k0 requested review from bundyo and vakrilov December 13, 2018 11:59
@sis0k0 sis0k0 self-assigned this Dec 13, 2018
@sis0k0 sis0k0 merged commit 7f67198 into master Dec 14, 2018
@sis0k0 sis0k0 deleted the sis0k0/ts-loader-all branch December 14, 2018 08:56
@dtopuzov dtopuzov mentioned this pull request Dec 17, 2018
Merged
sis0k0 added a commit that referenced this pull request Dec 17, 2018
@sis0k0
revert: feat(TypeScript): use ts-loader instead of `awesome-typescr…
3fd127c 
…ipt-loader` (#738)

This reverts commit 7f67198.
The commit introduces a breaking change and shouldn't be released in a
patch version.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bundyo bundyo bundyo approved these changes

@vakrilov vakrilov Awaiting requested review from vakrilov

Assignees

@sis0k0 sis0k0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sis0k0 @bundyo